This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86-64: Align the stack in __tls_get_addr [BZ #21609]
On 07/06/2017 04:30 PM, Carlos O'Donell wrote:
>> I'm not sure if the second patch is actually needed, and if the new
>> symbol is the right way to do it. It penalizes those who use modern and
>> fixed compilers by making their lives more complicated, while we should
>> do it the other way round (those who use unfixed compilers should
>> suffer, at least if the choice is between the two outcomes).
>
> Isn't the "suffering" just that you cannot build a compiler that is both
> compatible with the old glibc (performance loss) and new glibc (fastest
> performance)?
No, there is also the programmer inconvenience that they'd have to deal
with yet another -m flag.
If it's unconditional, you wouldn't be able to use the new GCC with the
alternate symbol enabled for glibc development (stable branch
maintenance, to be specific).
It's that kind of complexity I'm objecting to.
Thanks,
Florian