This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] i386: Increase MALLOC_ALIGNMENT to 16 [BZ #21120]

On 06/30/2017 10:48 AM, H.J. Lu wrote:
> On Fri, Jun 30, 2017 at 7:31 AM, Joseph Myers <joseph@codesourcery.com> wrote:
>> On Fri, 30 Jun 2017, Carlos O'Donell wrote:
>>
>>> (a) Should we add a new file malloc-alignment.h to specify a new parameter.
>>>     - Adds new file malloc-alignment.h.
>>>     - 2 new files.
>>
>> My preference is to add headers like this and so reduce the need for
>> #ifndef (that is, have a generic malloc-alignment that includes the
>> definition that's currently guarded with #ifndef).
>>
> 
> I like this idea.  Here is the patch.  OK for master?

Agreed, that's a better solution than my suggested (b).

LGTM.

-- 
Cheers,
Carlos.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]