This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Single threaded stdio optimization
On Friday 30 June 2017 06:08 PM, Szabolcs Nagy wrote:
> your code layout does not work for most
> io apis as they use _IO_acquire_lock/unlock
> which create a new scope for cancel cleanup
> handling.
>
> it only works with non-cancellation point
> apis (flag checks: feof, ferror) that just
> flockfile/funlockfile.
>
> i can change those two functions where it
> works but i dont think it will be any more
> maintainable.
Right, that won't work. There should be a cleaner way to do both, but I
can't think of one right now, so I'll let that go.
So the only open points right now is the comment I asked you to add
describing what/why you're doing this for stdio and the performance
question on x86. So Carlos, etc. who are monitoring this will tell you
when they're satisfied with your updated results.
Siddhesh