This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] rpcgen: make error() helper into a varargs func
- From: Florian Weimer <fweimer at redhat dot com>
- To: Mike Frysinger <vapier at gentoo dot org>, libc-alpha at sourceware dot org
- Date: Sun, 25 Jun 2017 18:14:38 +0200
- Subject: Re: [PATCH] rpcgen: make error() helper into a varargs func
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com F3C9A83F42
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F3C9A83F42
- References: <20170228202007.13529-1-vapier@gentoo.org>
On 02/28/2017 09:20 PM, Mike Frysinger wrote:
> A minor clean up to the code to avoid fixed buffers for output messages
> and to make error() more useful internally.
> ---
> sunrpc/proto.h | 2 +-
> sunrpc/rpc_parse.c | 13 ++-----------
> sunrpc/rpc_scan.c | 13 +++----------
> sunrpc/rpc_util.c | 28 ++++++++++++----------------
> sunrpc/rpc_util.h | 2 +-
> 5 files changed, 19 insertions(+), 39 deletions(-)
Patch is okay (with a ChangeLog entry). This seems to fix a
user-visible bug (sprintf crash), so it probably deserves a bug in Bugzilla.
Thanks,
Florian