This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Avoid .symver on common symbols [BZ #21666]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 23 Jun 2017 18:17:28 +0200
- Subject: Re: [PATCH] Avoid .symver on common symbols [BZ #21666]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CAC307F404
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CAC307F404
- References: <20170623161158.GA5384@gmail.com>
On 06/23/2017 06:11 PM, H.J. Lu wrote:
> +/* Define the variables used for the interface. Avoid .symver on common
> + symbol, which just creates a new common symbol, not an alias. */
> +char *loc1 = NULL;
> +char *loc2 = NULL;
I think __attribute__ ((nocommon)) without the initializer would be more
explicit. We already use that for _res in resolv/res_libc.c.
Does this result in a visible difference for applications? If yes,
please file a bug for this and reference it in the ChangeLog and commit
message.
Why didn't our test suite catch it?
Thanks,
Florian