This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix float128 uses of xlocale.h [committed]


On Fri, Jun 23, 2017 at 9:00 AM, Gabriel F. T. Gomes
<gftg@linux.vnet.ibm.com> wrote:
> On Thu, 22 Jun 2017 22:35:25 +0000
> Joseph Myers <joseph@codesourcery.com> wrote:
>
>> Three float128 files still include xlocale.h after it was removed.  I
>> don't know why this didn't cause problems for powerpc64le float128
>> testing; it did cause problems for my x86_64 float128 testing.  This
>> patch changes the includes to use bits/types/locale_t.h.
>
> It caused problems for powerpc64le testing, indeed.  But, my rebasing was
> a little outdated.  Thanks for doing this.

It's not a big deal, but .c files should probably be using <locale.h>
instead (on the usual "don't directly include bits headers without a
compelling reason" principles).

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]