This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: fix sysconf support for cache geometries

On 06/15/2017 03:55 PM, Adhemerval Zanella wrote:
> On 15/06/2017 17:45, Paul Clarke wrote:
>> Commit cdfbe5037f2f67bf5f560b73732b69d0fabe2314 added sysconf support
>> for cache geometries on powerpc, but mishandled errno.  For valid input
>> parameters, sysconf() should not set errno.
> 
> Do we have a testcase for it? If not I think we should add it.

We don't.  There are three obvious test cases for sysconf:
- ./nptl/tst-sysconf.c: ignores errno
- ./posix/tst-sysconf.c:  ignores errno
- ./sysdeps/unix/sysv/linux/powerpc/tst-sysconf.c
  Ironically (given the need for the subject patch), this correctly tests for errno changes but only for the _SC_LEVEL*, and only for powerpc.

PC
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]