This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86-64: Implement strcpy family IFUNC selectors in C


On 13/06/2017 17:46, H.J. Lu wrote:
>>> diff --git a/sysdeps/x86_64/multiarch/stpncpy-c.c b/sysdeps/x86_64/multiarch/stpncpy-c.c
>>> index 2fde77d..62f69b5 100644
>>> --- a/sysdeps/x86_64/multiarch/stpncpy-c.c
>>> +++ b/sysdeps/x86_64/multiarch/stpncpy-c.c
>>> @@ -1,8 +1,7 @@
>>>  #define STPNCPY __stpncpy_sse2
>>> -#ifdef SHARED
>>> +#undef weak_alias
>>> +#define weak_alias(__stpncpy, stpncpy)
>>>  #undef libc_hidden_def
>>> -#define libc_hidden_def(name) \
>>> -  __hidden_ver1 (__stpncpy_sse2, __GI___stpncpy, __stpncpy_sse2);
>>> -#endif
>>> +#define libc_hidden_def(stpncpy)
>>>
>>> -#include "stpncpy.c"
>>> +#include <string/stpncpy.c>
>>
>> Shouldn't we add a copyright header on this file (same for sysdeps/x86_64/multiarch/strncpy-c.c)?
> 
> A separate patch?

Fair enough.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]