This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 5/6] PowerPC64 ENTRY_TOCLESS
Alan Modra <amodra@gmail.com> writes:
> On Tue, Jun 13, 2017 at 09:23:12AM -0300, Tulio Magno Quites Machado Filho wrote:
>> Alan Modra <amodra@gmail.com> writes:
>>
>> There are 2 more functions that could benefit from this optimization as well:
>> - sysdeps/powerpc/fpu/s_fmaf.S
>> - sysdeps/powerpc/fpu/s_fma.S
>>
>> Notice they're reused in powerpc32.
>
> I see. I hadn't looked for included files. This will mean modifying
> powerpc32/sysdep.h to add
>
> #define ENTRY_TOCLESS(name) ENTRY(name)
Looks good to me.
>> > diff --git a/sysdeps/powerpc/powerpc64/power8/strcasestr.S b/sysdeps/powerpc/powerpc64/power8/strcasestr.S
>> > index 6ac6572..3f59cb0 100644
>> > --- a/sysdeps/powerpc/powerpc64/power8/strcasestr.S
>> > +++ b/sysdeps/powerpc/powerpc64/power8/strcasestr.S
>> > @@ -85,7 +85,7 @@
>> > /* TODO: change this to .machine power8 when the minimum required binutils
>> > allows it. */
>> > .machine power7
>> > -EALIGN (STRCASESTR, 4, 0)
>> > +ENTRY (STRCASESTR, 4)
>> > CALL_MCOUNT 2
>> > mflr r0 /* Load link register LR to r0. */
>> > std r31, -8(r1) /* Save callers register r31. */
>>
>>
>> Isn't it safe to use ENTRY_TOCLESS here too?
>
> No, the code uses @got@tprel(r2).
Ack.
Thanks!
--
Tulio Magno