This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/6] Remove __need_schedparam and __cpu_set_t_defined.

From: Zack Weinberg <zackw at panix dot com>
To: Andreas Schwab <schwab at suse dot de>
Cc: GNU C Library <libc-alpha at sourceware dot org>, Joseph Myers <joseph at codesourcery dot com>
Date: Tue, 13 Jun 2017 07:28:43 -0400
Subject: Re: [PATCH 2/6] Remove __need_schedparam and __cpu_set_t_defined.
Authentication-results: sourceware.org; auth=none
References: <20170610171738.22362-1-zackw@panix.com> <20170610171738.22362-3-zackw@panix.com> <mvm8tkwl2xv.fsf@suse.de>

On Tue, Jun 13, 2017 at 4:14 AM, Andreas Schwab <schwab@suse.de> wrote:
> On Jun 10 2017, Zack Weinberg <zackw@panix.com> wrote:
>> +/* Size definition for CPU sets.  */
>> +# define __CPU_SETSIZE       1024
>> +# define __NCPUBITS  (8 * sizeof (__cpu_mask))
>
> The directives should not be indented.  The MI guard doesn't count for
> nesting.

Fixed now.  This is because I copied the text verbatim from the old
bits/sched.h.

zw

References:
- [PATCH 0/6] Header file cleanups revised again
  - From: Zack Weinberg
- [PATCH 2/6] Remove __need_schedparam and __cpu_set_t_defined.
  - From: Zack Weinberg
- Re: [PATCH 2/6] Remove __need_schedparam and __cpu_set_t_defined.
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]