This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/5] Remove __need macros from stdio.h and wchar.h.
On Thu, Jun 8, 2017 at 4:34 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Thu, 8 Jun 2017, Zack Weinberg wrote:
>
>> On Tue, Jun 6, 2017 at 11:26 AM, Joseph Myers <joseph@codesourcery.com> wrote:
>> > On Mon, 5 Jun 2017, Zack Weinberg wrote:
>> >> wint_t is a little finicky because it might be defined by stddef.h, which
>> >> belongs to the compiler.
>> >>
>> >> In addition to the _types_, a bunch of other declarations shared between
>> >> wctype.h and wchar.h are factored out to their own header.
>> >
>> > This patch is OK.
>>
>> Committed.
>>
>> Do you think you might have time to review the rest of the patches
>> before the 2.26 deadline?
>
> I'm still uneasy about reviewing public API additions (adding error_t
> globally; adding sys/uio_ext.h) mixed in with header cleanups. In my view
> such additions really need to be proposed separately from cleanups, and
> reach a wider consensus, as well as probably including NEWS entries and
> documentation in the manual.
I will consider it more carefully, but I do not currently think it is
practical to split either of those patches. If that means you (or
anyone) feel they must be reviewed to a higher standard, so be it.
Note that I don't expect anyone to *want* to include sys/uio_ext.h
directly; its purpose is separation of concerns when writing new
ports.
zw