This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] [BZ #21528] rtld: Add _dl_strtoul
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Thu, 8 Jun 2017 16:21:37 -0300
- Subject: Re: [PATCH] [BZ #21528] rtld: Add _dl_strtoul
- Authentication-results: sourceware.org; auth=none
- References: <20170605195943.GA19003@lucon.org> <CAMe9rOr1DLktri2Z1wzODp91WSpqahH=dYhv_kf3SNPVZgEaJA@mail.gmail.com>
On 08/06/2017 14:46, H.J. Lu wrote:
> On Mon, Jun 5, 2017 at 12:59 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>> There are 2 minimal strtoul implementations in ld.so:
>>
>> 1. __strtoul_internal in elf/dl-minimal.c.
>> 2. tunables_strtoul in elf/dl-tunables.c.
>>
>> This patch adds _dl_strtoul to replace them. Tested builds with and
>> without --enable-tunables.
>>
>> OK for master?
>>
>> Thanks.
>>
>> H.J.
>> ---
>> [BZ #21528]
>> * elf/dl-minimal.c (__strtoul_internal): Removed.
>> (strtoul): Likewise.
>> * elf/dl-misc.c (_dl_strtoul): New function.
>> * elf/dl-tunables.c (tunables_strtoul): Removed.
>> (tunable_initialize): Replace tunables_strtoul with _dl_strtoul.
>> * elf/rtld.c (process_envvars): Likewise.
>> * sysdeps/unix/sysv/linux/dl-librecon.h (_dl_osversion_init):
>> Likewise.
>> * sysdeps/generic/ldsodefs.h (_dl_strtoul): New prototype.
>>
>
> Here is the updated patch. Any comments, objections?
>
LGTM, thanks.