This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 2/2] float128: Add strfromf128, strtof128, and wcstof128 to the manual


On Wed, 7 Jun 2017, Gabriel F. T. Gomes wrote:

>   - Remove @var{N} from the function names and return types in the
>     @deftypefun and @deftypefunx blocks, because @var{N} causes errors in
>     'make html' and 'make info' (make 'pdf' was working fine).

The patch is OK, fixed as noted, provided this issue is reported to 
upstream Texinfo (after all, at some point we'd like to use @var{N} 
properly in the names and types once the minimum Texinfo version for glibc 
is high enough to ensure a fix).

> +@comment stdlib.h
> +@comment ISO/IEC TS 18661-3
> +@deftypefun _FloatN strtofN (const char *@var{string}, char **@var{tailptr})
> +@deftypefunx _FloatNx strtofN (const char *@var{string}, char **@var{tailptr})

The second one should be strtofNx.

Of course a subsequent patch before the float128 support is actually 
enabled will need to document all the libm interfaces, both functions and 
macros, for the new type.  (That is, where the corresponding interfaces 
for existing types are documented, documentation needs adding for the new 
type; this is not a requirement to document things where the float / 
double / long double interfaces aren't documented either.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]