This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 9/9] float128: Add test-{float128,ifloat128,float128-finite}


On Fri, 2 Jun 2017, Gabriel F. T. Gomes wrote:

> +#define TEST_FLOATN 1
> +#define __STDC_WANT_IEC_60559_BFP_EXT__
> +#define __STDC_WANT_IEC_60559_TYPES_EXT__

You should not need the definition of __STDC_WANT_IEC_60559_BFP_EXT__.  
The point of defining __STDC_WANT_IEC_60559_TYPES_EXT__ here is, I 
presume, to make the compiler-provided float.h define macros for 
_Float128 (_GNU_SOURCE, defined by default, ensures that glibc-provided 
headers declare everything expected for the new type).  The only thing 
__STDC_WANT_IEC_60559_BFP_EXT__ does for the compiler-provided float.h is 
make it define CR_DECIMAL_DIG, which is not used by glibc.

The patch is OK with the definition of __STDC_WANT_IEC_60559_BFP_EXT__ 
removed.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]