This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 2/2] posix: Implement preadv2 and pwritev2

On 06/04/2017 09:42 AM, H.J. Lu wrote:
> On Sat, Jun 3, 2017 at 8:28 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> On Jun 03 2017, "H.J. Lu" <hjl.tools@gmail.com> wrote:
>>
>>> X32 inherits LO_HI_LONG from x86-64.  If we change x86-64
>>> LO_HI_LONG, x32 needs to redefine LO_HI_LONG.
>>
>> Your LO_HI_LONG_FLAGS doesn't work for x32 either.
>>
> 
> My patch redefined LO_HI_LONG_FLAGS for x32.   Here is an alternate
> patch which defines different LO_HI_LONGs for x86-64 and x32.
> 
> Tested on x86-64 and x32.

This patch looks good to me, but since today is Sunday, please wait at
least 24 hours for any other comments before committing.

zw
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]