This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] nptl/tst-robust-fork: Increase timeout to 30 seconds.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 18 May 2017 14:59:38 -0400
- Subject: [PATCH] nptl/tst-robust-fork: Increase timeout to 30 seconds.
- Authentication-results: sourceware.org; auth=none
The default test timeout is 20 seconds.
On certain x86_64 hardware I can see tst-robust-fork test take 22 seconds on average.
This results in spurious failures.
I suggest we increase the timeout to 25 seconds and add a note about this.
If nobody objects I'll check this in at some point next week when I get a
free minute.
I don't know if it's particularly useful to list the kernel version or
hardware under which the slow timing came from i.e. linux 4.10 on an older
i5-4690K.
2017-05-18 Carlos O'Donell <carlos@redhat.com>
* nptl/tst-robust-fork.c (TIMEOUT): Define.
diff --git a/nptl/tst-robust-fork.c b/nptl/tst-robust-fork.c
index 4a12ff0..d2c8a5a 100644
--- a/nptl/tst-robust-fork.c
+++ b/nptl/tst-robust-fork.c
@@ -25,6 +25,12 @@
#include <support/xunistd.h>
#include <sys/mman.h>
+/* This test can take as long as 22 seconds on some x86_64 hardware,
+ so increase the timeout to 25 seconds to allow it to pass. More
+ than half of the time is spent in page_fault() in the kernel and
+ do_lookup_x() in ld.so. */
+#define TIMEOUT 25
+
/* Data shared between processes. */
struct shared
{
---
--
Cheers,
Carlos.