This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [PATCH] mips: Fix store/load gp registers to/from ucontext_t
On Thu, 18 May 2017, Gordana Cmiljanovic wrote:
> I have a simple test case which manifests getcontext() failure but since
> it is mips only test I was not sure where to add it. Do you have any
> suggestion?
It could be added to e.g. sysdeps/unix/sysv/linux/mips/ (or .../mips32/ if
o32-specific). Such a file would need to have a clearly MIPS-specific
name so it can't conflict with any architecture-independent test. The
appropriate sysdeps Makefile would need to add it to tests, conditional on
the value of $(subdir).
> I would say that mips N32 and mips64 are not affected by the change,
> since SZREG for them is 8 as per:
They shouldn't be affected - but to make sure there aren't any bugs in the
change that accidentally affect them, stripped installed shared libraries
before and after the change should be compared for all combinations of n32
or n64, BE or LE (the binaries should be identical).
--
Joseph S. Myers
joseph@codesourcery.com