This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add __BEGIN_DECLS and __END_DECLS for C++

From: Zack Weinberg <zackw at panix dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Thu, 11 May 2017 10:43:30 -0400
Subject: Re: [PATCH] Add __BEGIN_DECLS and __END_DECLS for C++
Authentication-results: sourceware.org; auth=none
References: <20170511141836.GB26086@intel.com> <CAKCAbMgOB5eNNgoWjkMM-GHVxgfVs307mZRYvvXZ35gUgDuOXA@mail.gmail.com> <CAMe9rOo8Y8+hm8KNS3sQX_q_qtM8stWbdad9yO5c1nX1w0ag2Q@mail.gmail.com>

On Thu, May 11, 2017 at 10:39 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, May 11, 2017 at 7:29 AM, Zack Weinberg <zackw@panix.com> wrote:
>> On Thu, May 11, 2017 at 10:18 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>>> Add __BEGIN_DECLS and __END_DECLS to support C++.
>>>
>>> Any comments?
>>
>> Could you please explain why you found this to be necessary?
>> ifunc-impl-list.h is an internal header which should never be compiled
>> as C++ in the first place.
>
> I am integrating memcpy_benchmark.cc:
>
> https://gist.github.com/ekelsen/b66cc085eb39f0495b57679cdb1874fa
>
> into glibc benchtests.  It is a C++ program.

This program does not appear to need ifunc-impl-list.h.  Please elaborate.

zw

Follow-Ups:
- Re: [PATCH] Add __BEGIN_DECLS and __END_DECLS for C++
  - From: H.J. Lu

References:
- [PATCH] Add __BEGIN_DECLS and __END_DECLS for C++
  - From: H.J. Lu
- Re: [PATCH] Add __BEGIN_DECLS and __END_DECLS for C++
  - From: Zack Weinberg
- Re: [PATCH] Add __BEGIN_DECLS and __END_DECLS for C++
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]