This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Remove __ASSUME_STATFS_F_FLAGS


On 05/10/2017 07:50 PM, Joseph Myers wrote:
-#ifndef __ASSUME_STATFS_F_FLAGS
-  if ((fsbuf->f_flags & ST_VALID) == 0)
-    /* Determining the flags is tricky.  We have to read /proc/mounts or
-       the /etc/mtab file and search for the entry which matches the given
-       file.  The way we can test for matching filesystem is using the
-       device number.  */
-    buf->f_flag = __statvfs_getflags (name, fsbuf->f_type, fd);
-  else
-#endif
-    buf->f_flag = fsbuf->f_flags ^ ST_VALID;
+  buf->f_flag = fsbuf->f_flags ^ ST_VALID;

Should we check the presence of the flag and return ENOSYS or abort if it missing?

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]