This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: add sysconf support for cache geometries
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Paul Clarke <pc at us dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 28 Apr 2017 15:47:37 +0000
- Subject: Re: [PATCH] powerpc: add sysconf support for cache geometries
- Authentication-results: sourceware.org; auth=none
- References: <c58aec33-3d25-0a8f-ca49-e323a46647cb@us.ibm.com>
On Fri, 28 Apr 2017, Paul Clarke wrote:
> * sysdeps/unix/sysv/linux/powerpc/tst-sysconf.c: New file.
This suffers the usual problem of adding a sysdeps test with the same name
as a non-sysdeps test: it would override nptl/tst-sysconf.c and
posix/tst-sysconf.c on systems using this sysdeps directory.
Perhaps we should have a naming convention for sysdeps tests, that all
tests added in sysdeps directories (as opposed to files there that wrap
non-sysdeps test implementations) include something system-specific in
their names, so this might be test-powerpc-linux-sysconf.c and linux/
tests might be renamed to test-linux-*.c, to avoid accidental overriding.
> +#define TEST_FUNCTION do_test ()
> +#include "../test-skeleton.c"
New tests should be using <support/test-driver.c>. See:
https://sourceware.org/glibc/wiki/Testing/Testsuite#Writing_a_test_case
--
Joseph S. Myers
joseph@codesourcery.com