This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Basic requirements for supporting OS and machine ports.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Richard Henderson <rth at redhat dot com>, Mike Frysinger <vapier at gentoo dot org>, Andreas Schwab <schwab at suse dot de>, Chris Metcalf <cmetcalf at mellanox dot com>, Chung-Lin Tang <chunglin_tang at mentor dot com>, Steven Munroe <sjmunroe at us dot ibm dot com>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, David Miller <davem at davemloft dot net>, Siddhesh Poyarekar <siddhesh at gotplt dot org>, Aurelien Jarno <aurelien at aurel32 dot net>, Adam Conrad <adconrad at 0c3 dot net>
- Date: Tue, 18 Apr 2017 22:02:33 -0400
- Subject: Re: Basic requirements for supporting OS and machine ports.
- Authentication-results: sourceware.org; auth=none
- References: <c501b05e-3ae1-5bc8-b5a7-b6c2dabb98bc@redhat.com> <545bd56b-3298-90ca-2e86-b3cf64de4c3a@redhat.com> <CAMe9rOrAvZDrn1a8DirSGgrR9Usj7Nekj19G8w9x4dXEintsPQ@mail.gmail.com>
On 04/18/2017 01:15 PM, H.J. Lu wrote:
> On Tue, Apr 18, 2017 at 9:49 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 04/18/2017 03:47 PM, Carlos O'Donell wrote:
>>>
>>> (a) If your OS and machine port has build-many-glibcs.py support then all
>>> maintainers will strive to ensure that their changes do not break
>>> those
>>> OS and machine combinations supported by the script, and will work to
>>> correct any such past breakage.
>>
>>
>> I don't want to see running build-many-glibcs.py as a requirement for
>> posting patches. The main reason for that is that it's rather expensive
>> (either you need to be very patient, or you need a fairly big machine).
>
> I agree.
Thanks for the feedback.
Hopefully my comments downthread make it clear that I don't intend for
anyone to run build-many-glibcs.py for each commit, but that if it breaks
that we are accountable to determining why it broke because it's a minimum
requirement for supporting an OS or a machine port.
To give an example: You checkin a patch you only tested on ppc64le and
AArch64 and it breaks build-many-glibcs.py for s390x. We would expect
that the committer of that change is on the hook for figuring out why
s390x broke and fixing it or reverting the change.
--
Cheers,
Carlos.