This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] localedata: Remove trailing spaces [BZ #20275]


I'm happy to send the ne_NP change to a Nepali colleague for review,
but I wouldn't hold it up for that.

cjl

On Thu, Apr 13, 2017 at 8:08 PM, Rafal Luzynski
<digitalfreak@lingonborough.com> wrote:
> 13.04.2017 12:25 Pravin Satpute <psatpute@redhat.com> wrote:
>> >----- Original Message -----
>> >From: "Rafal Luzynski" <digitalfreak@lingonborough.com>
>> >To: libc-alpha@sourceware.org
>> >Sent: Saturday, April 8, 2017 5:05:03 AM
>> >Subject: Re: [PATCH] localedata: Remove trailing spaces [BZ #20275]
>> >
>> >Ping! Is there anybody able to review this patch?
>> >
>> >https://sourceware.org/ml/libc-alpha/2017-03/msg00029.html
>>
>> Hi Rafal,
>>
>> I have reviewed this patch today and it looks good to me. I have already
>> provided comments on bugzilla [1]
>> Again adding it here.
>>
>> - Testing installing copr repo, its working fine for Indian locales.
>> - Applied patch and generated all locales, its working fine.
>> - Verified patch, it only removes only <U0020> from locales and not creating
>> any other typo kind mistake or unnecessary removal.
>>
>> Best Regards,
>> Pravin Satpute
>>
>> 1. https://sourceware.org/bugzilla/show_bug.cgi?id=20275
>
> Thank you, Pravin.  Your review is exactly what I needed.
>
> So, taking into account that:
>
> - now we have *_IN, sq_AL, and quz_PE locales verified,
> - it may be difficult to reach the native speakers of
>   the_NP, ne_NP, ln_CD, ht_HT, mt_MT, and so_*,
> - all changes seem to be reasonable,
> - in case of so_* this is only the change of the space character
>   encoding, there is no change in the output,
>
> can anybody please commit this patch?  Links above.
>
> Best regards,
>
> Rafal


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]