This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Update elf tests to use the support test driver.


On 03/30/2017 05:55 PM, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> There is no need to remove the static definition from this function and
>> for all other every tests which includes the test-driver.c (since it will
>> end up creating the main entrypoint anyway). I would avoid change it.
> Agreed.  The corresponding ChangeLog bit looks a bit strange as well:
>
> 	* elf/next.c: Import support/test-driver.c instead of
> 	test-skeleton.c and delete TEST_FUNCTION macro definition.
> 	(do_test): adjust return attribute.
> 	* elf/nodelete.c: Likewise.
>
> I don't think any function attribute is changed in the patch.
>
Thanks for the review, I will send a v2 patch soon.

Side note: the original tst-tls-manydynamic.c code uses xpthread_* functions. So I had to include support/xthread.h to avoid its breakage. In test-skeleton.c you can see the following:

#ifdef _PTHREAD_H
# include <support/xthread.h>
#endif  /* _PTHREAD_H */

So I'm considering to add this same block in test-driver.c since it will ease the migration of tests that use xpthread_*. Any objection to this change?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]