This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Update elf tests to use the support test driver.
On 30/03/2017 17:55, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> There is no need to remove the static definition from this function and
>> for all other every tests which includes the test-driver.c (since it will
>> end up creating the main entrypoint anyway). I would avoid change it.
>
> Agreed. The corresponding ChangeLog bit looks a bit strange as well:
>
> * elf/next.c: Import support/test-driver.c instead of
> test-skeleton.c and delete TEST_FUNCTION macro definition.
> (do_test): adjust return attribute.
> * elf/nodelete.c: Likewise.
>
> I don't think any function attribute is changed in the patch.
>
Also, if you have time I would ask you if you can update the Testing
wiki page onthe 'Writing a test case' [1]. It would be good to just
have it aligned with current practices.
[1] https://sourceware.org/glibc/wiki/Testing/Testsuite.