This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] sparc: Fix .udiv plt on libc
On 16/03/2017 13:59, Adhemerval Zanella wrote:
>
>
> On 16/03/2017 11:45, Florian Weimer wrote:
>> On 03/16/2017 02:43 PM, Adhemerval Zanella wrote:
>>> To avoid it, this patch uses the linker option --wrap to replace all
>>> the internal libc.so .udiv calls to the wrapper __wrap_.udiv. Along
>>> with strong alias in the udiv implementations, it makes linker do
>>> local calls.
>>
>> I think we already use a different mechanism for a similar purpose, via sysdeps/generic/symbol-hacks.h. Maybe it's possible to reuse that?
>>
>> Thanks,
>> Florian
>
> The problem is now that divdi3 is not provided by glibc anymore we can't
> use the same trick since __divdi3 and __moddi3 will be provided by libgcc.
> Another way to actually redefine .udiv is to either still keep using divdi3
> for sparc32 .
>
Any more impeding remark about this patch?