This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] posix_spawn: use a larger min stack for -fstack-check [BZ #21253]


On 03/20/2017 10:28 AM, Mike Frysinger wrote:
> On 20 Mar 2017 13:40, Szabolcs Nagy wrote:
>> On 17/03/17 21:21, Mike Frysinger wrote:
>>> GNU style says it's wrong:
>>> https://www.gnu.org/prep/standards/standards.html#index-spaces-before-open_002dparen
>>
>> that coding style rule is obviously wrong
>> as it breaks macro definitions, you cannot
>> always put spaces before open-parentheses.
> 
> obviously the style guide isn't going to force something that the
> language disallows
> 
>> in glibc it seems the rule was that there
>> is space in function calls but not necessarily
>> in macro invocation.
> 
> unless there's an explicit rule somewhere on the glibc side, then
> we should be bringing things in line with the style guide.  you
> can't tell people "follow the GNU style guide" and then sometimes
> be like "oh but not here -- you just have 'to know'".

I agree. We should follow the GNU style in all possible situations.

This hasn't been fixed because nobody has bothered to run a script
over everything and submit a patch to clean it all up :-)

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]