This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/4] Add IS_IN (testsuite) and remaining fixes.
On Mon, Feb 20, 2017 at 10:13 AM, Carlos O'Donell <carlos@redhat.com> wrote:
>
> This change is looking good, it is a step in the right direction, and the
> addition of '*-internal' markup is useful.
>
> I still think we need a few improvements.
>
> I'd like two senior developers to review this.
That seems fair. I expect not to have time to do any further work on
this until the weekend, so I want to say thank you now for the quick
reviews.
> - This is a step in the right direction. My instinct is to want to move
> all the internal dependencies into functions in support/, but that's
> quite a bit of work. Either way they would have to be identified before
> being moved and your work does just that. Eventually I would hope that
> all the tests go back to being compiled with tests, we remove tests-internal,
> and only support/ functions can view the glibc internals through a well
> defined API.
I agree with this in principle but I suspect it may be hard,
especially for the tests which are digging around inside the guts of
the dynamic linker. And I want to be clear that I don't plan to do
any of it. I don't have the time or the expertise.
zw