This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Pre-approval for #include adjustments to the testsuite
On 02/16/2017 11:59 AM, Zack Weinberg wrote:
> On Thu, Feb 16, 2017 at 11:53 AM, Carlos O'Donell <carlos@redhat.com> wrote:
>> On 02/16/2017 10:12 AM, Joseph Myers wrote:
>>> On Thu, 16 Feb 2017, Zack Weinberg wrote:
>>>> I'm asking for blanket pre-approval to commit
>>>> additions and/or removals of #include lines to files that are part of
>>>> the testsuite, making no other changes.
>>>
>>> We already have
>>> <https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes>
>>> "Anyone can commit a change adding missing #include directives where it is
>>> clear what the right header is for functionality used in a source file.
>>
>> Agreed.
>
> OK, I will proceed with these patches.
>
> Follow-up question: In several cases, include/ wrappers include
> secondary headers that they do not themselves appear to need. What do
> people think of removing such inclusions? Useful, waste of time,
> harmful? I would not consider such patches to be trivial.
I would avoid it for now, only because it detracts from your awesome goal :-)
--
Cheers,
Carlos.