This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc64: strrchr optimization for power8
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Date: Mon, 13 Feb 2017 10:18:35 -0600
- Subject: Re: [PATCH] powerpc64: strrchr optimization for power8
- Authentication-results: sourceware.org; auth=none
- References: <1486616454-14704-1-git-send-email-raji@linux.vnet.ibm.com>
On 2/8/17 11:00 PM, Rajalakshmi Srinivasaraghavan wrote:
+ /* r4 is changed now ,if its passed as more chars
+ check for null again */
Not sure without looking at the code closer, but should this
read like the following???
/* r4 is changed now. If it's passed more chars, then check for
null again. */
+ /* if there are more than one 0xff in r11, find the first pos of ff
+ in r11 and fill r10 with 0 from that position */
First word should be capitalized and there is no final '.' and two
spaces at the end of the sentence. I would also write out position
rather than using "pos" like you did at the end of the sentence.
+ vsl v9, v8, v9 /* v9 = 0x4040404040404040. */
Two spaces after the '.'.
Peter