This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Clean up libm vector tests exception test disabling [committed]

From: Joseph Myers <joseph at codesourcery dot com>
To: <libc-alpha at sourceware dot org>
Date: Tue, 7 Feb 2017 23:07:05 +0000
Subject: Clean up libm vector tests exception test disabling [committed]
Authentication-results: sourceware.org; auth=none

The libm vector tests disable tests of exception raising via defining
macros EXCEPTION_TESTS_float and EXCEPTION_TESTS_double to 0 in the
headers for individual vector lengths.

As EXCEPTION_TESTS is used in code in libm-test-driver.c that is
otherwise ready to be built only once per type, this is not a good
idea; it's better to define TEST_EXCEPTIONS appropriately so that
flag_test_exceptions then gets initialized appropriately.
Furthermore, it's better to do this just once, in test-math-vector.h,
since there is no actual dependence on the vector length or type.
This patch duly makes that change.

Tested for x86_64.  Committed.

2017-02-07  Joseph Myers  <joseph@codesourcery.com>

	* math/test-math-finite.h (TEST_EXCEPTIONS): New macro.
	* math/test-math-no-finite.h (TEST_EXCEPTIONS): Likewise.
	* math/test-math-vector.h (TEST_EXCEPTIONS): Likewise.
	* math/test-math-no-inline.h (TEST_EXCEPTIONS): Remove macro.
	* math/test-double-vlen2.h (EXCEPTION_TESTS_double): Likewise.
	* math/test-double-vlen4.h (EXCEPTION_TESTS_double): Likewise.
	* math/test-double-vlen8.h (EXCEPTION_TESTS_double): Likewise.
	* math/test-float-vlen4.h (EXCEPTION_TESTS_float): Likewise.
	* math/test-float-vlen8.h (EXCEPTION_TESTS_float): Likewise.
	* math/test-float-vlen16.h (EXCEPTION_TESTS_float): Likewise.

diff --git a/math/test-double-vlen2.h b/math/test-double-vlen2.h
index 58d029a..06571cf 100644
--- a/math/test-double-vlen2.h
+++ b/math/test-double-vlen2.h
@@ -20,7 +20,6 @@
 #include "test-math-no-inline.h"
 #include "test-math-vector.h"
 
-#define EXCEPTION_TESTS_double 0
 #define ROUNDING_TESTS_double(MODE) ((MODE) == FE_TONEAREST)
 
 #define VEC_SUFF _vlen2
diff --git a/math/test-double-vlen4.h b/math/test-double-vlen4.h
index 5ebcd13..4725470 100644
--- a/math/test-double-vlen4.h
+++ b/math/test-double-vlen4.h
@@ -20,7 +20,6 @@
 #include "test-math-no-inline.h"
 #include "test-math-vector.h"
 
-#define EXCEPTION_TESTS_double 0
 #define ROUNDING_TESTS_double(MODE) ((MODE) == FE_TONEAREST)
 
 #define VEC_SUFF _vlen4
diff --git a/math/test-double-vlen8.h b/math/test-double-vlen8.h
index 8d9049e..a1254ae 100644
--- a/math/test-double-vlen8.h
+++ b/math/test-double-vlen8.h
@@ -20,7 +20,6 @@
 #include "test-math-no-inline.h"
 #include "test-math-vector.h"
 
-#define EXCEPTION_TESTS_double 0
 #define ROUNDING_TESTS_double(MODE) ((MODE) == FE_TONEAREST)
 
 #define VEC_SUFF _vlen8
diff --git a/math/test-float-vlen16.h b/math/test-float-vlen16.h
index 9388d77..b6d209e 100644
--- a/math/test-float-vlen16.h
+++ b/math/test-float-vlen16.h
@@ -20,7 +20,6 @@
 #include "test-math-no-inline.h"
 #include "test-math-vector.h"
 
-#define EXCEPTION_TESTS_float 0
 #define ROUNDING_TESTS_float(MODE) ((MODE) == FE_TONEAREST)
 
 #define VEC_SUFF _vlen16
diff --git a/math/test-float-vlen4.h b/math/test-float-vlen4.h
index 0a3a254..4bac669 100644
--- a/math/test-float-vlen4.h
+++ b/math/test-float-vlen4.h
@@ -20,7 +20,6 @@
 #include "test-math-no-inline.h"
 #include "test-math-vector.h"
 
-#define EXCEPTION_TESTS_float 0
 #define ROUNDING_TESTS_float(MODE) ((MODE) == FE_TONEAREST)
 
 #define VEC_SUFF _vlen4
diff --git a/math/test-float-vlen8.h b/math/test-float-vlen8.h
index f744dc5..e72257c 100644
--- a/math/test-float-vlen8.h
+++ b/math/test-float-vlen8.h
@@ -20,7 +20,6 @@
 #include "test-math-no-inline.h"
 #include "test-math-vector.h"
 
-#define EXCEPTION_TESTS_float 0
 #define ROUNDING_TESTS_float(MODE) ((MODE) == FE_TONEAREST)
 
 #define VEC_SUFF _vlen8
diff --git a/math/test-math-finite.h b/math/test-math-finite.h
index d081ff2..e1ab934 100644
--- a/math/test-math-finite.h
+++ b/math/test-math-finite.h
@@ -18,3 +18,4 @@
 
 #define TEST_FINITE 1
 #define TEST_ERRNO 0
+#define TEST_EXCEPTIONS 1
diff --git a/math/test-math-no-finite.h b/math/test-math-no-finite.h
index 8150962..c4b8246 100644
--- a/math/test-math-no-finite.h
+++ b/math/test-math-no-finite.h
@@ -17,3 +17,4 @@
    <http://www.gnu.org/licenses/>.  */
 
 #define TEST_FINITE 0
+#define TEST_EXCEPTIONS 1
diff --git a/math/test-math-no-inline.h b/math/test-math-no-inline.h
index 81dde30..83ba170 100644
--- a/math/test-math-no-inline.h
+++ b/math/test-math-no-inline.h
@@ -17,7 +17,6 @@
    <http://www.gnu.org/licenses/>.  */
 
 #define TEST_INLINE 0
-#define TEST_EXCEPTIONS 1
 
 #ifndef __NO_MATH_INLINES
 # define __NO_MATH_INLINES
diff --git a/math/test-math-vector.h b/math/test-math-vector.h
index 63b6385..8a9ae9c 100644
--- a/math/test-math-vector.h
+++ b/math/test-math-vector.h
@@ -19,6 +19,7 @@
 #define TEST_MATHVEC 1
 #define TEST_FINITE 0
 #define TEST_ERRNO 0
+#define TEST_EXCEPTIONS 0
 
 #define CNCT(x, y) x ## y
 #define CONCAT(a, b) CNCT (a, b)

-- 
Joseph S. Myers
joseph@codesourcery.com

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]