This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 3/5] manual: Add new header and standards annotations.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Rical Jasan <ricaljasan at pacific dot net>
- Cc: <libc-alpha at sourceware dot org>, <mtk dot manpages at gmail dot com>, <carlos at redhat dot com>
- Date: Tue, 7 Feb 2017 16:40:51 +0000
- Subject: Re: [PATCH v2 3/5] manual: Add new header and standards annotations.
- Authentication-results: sourceware.org; auth=none
- References: <20161206105525.21117-1-ricaljasan@pacific.net> <20161206105525.21117-4-ricaljasan@pacific.net> <alpine.DEB.2.20.1612071624470.23761@digraph.polyomino.org.uk> <665e49d4-dfa0-e14d-a793-d4acdca8e617@pacific.net> <alpine.DEB.2.20.1612081401130.3473@digraph.polyomino.org.uk> <7dd6da88-601f-e6f2-1f16-c24d7fdf84e2@pacific.net> <alpine.DEB.2.20.1612141818020.32751@digraph.polyomino.org.uk> <8c01ffc4-fcee-d584-bfab-d74a0b552b77@pacific.net> <8e8b0d56-b001-1870-1b5c-9895a1301c07@pacific.net> <alpine.DEB.2.20.1612151300180.15350@digraph.polyomino.org.uk> <0d5758f3-52bb-31cb-21e2-d218ace98065@pacific.net>
On Mon, 6 Feb 2017, Rical Jasan wrote:
> The commit message in [1], however, contains the rationale behind these
> changes, which is lost if I break the chapters apart and give specifics.
> If I were to include the rationale in every chapter, that would be
> overly redundant. I feel the patches speak for themselves, given the
> rationale, but I also understand the need to ease review for larger diffs.
I'd say the first commit should give the general description of the issues
/ design of changes being made, then describe what's being done in that
particular commit. Subsequent ones might then refer back to the first
commit / submission of that patch for details of the overall issue /
changes.
--
Joseph S. Myers
joseph@codesourcery.com