This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 3/5] manual: Add new header and standards annotations.


On Mon, 6 Feb 2017, Rical Jasan wrote:

> The commit message in [1], however, contains the rationale behind these
> changes, which is lost if I break the chapters apart and give specifics.
>  If I were to include the rationale in every chapter, that would be
> overly redundant.  I feel the patches speak for themselves, given the
> rationale, but I also understand the need to ease review for larger diffs.

I'd say the first commit should give the general description of the issues 
/ design of changes being made, then describe what's being done in that 
particular commit.  Subsequent ones might then refer back to the first 
commit / submission of that patch for details of the overall issue / 
changes.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]