This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Bug 20116: Fix use after free in pthread_create().
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: Torvald Riegel <triegel at redhat dot com>, Carlos O'Donell <carlos at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Alexey Makhalov <amakhalov at vmware dot com>, Florian Weimer <fweimer at redhat dot com>
- Date: Fri, 27 Jan 2017 09:31:11 +0530
- Subject: Re: [PATCH] Bug 20116: Fix use after free in pthread_create().
- Authentication-results: sourceware.org; auth=none
- References: <b7974946-1706-6d90-7288-7df7833a970b@redhat.com> <1485438779.16721.14.camel@redhat.com>
On Thursday 26 January 2017 07:22 PM, Torvald Riegel wrote:
> This is OK, thanks. I have a few minor comments on the wording of the
> concurrency notes, but this shouldn't hold up committing this patch.
>
> Overall, the notes are good and really helpful, I think. Good
> description of the high-level synchronization scheme, which the
> implementation can then be verified against.
>
> The fact that the high-level description points out an existing bug
> (19511) is also a good thing. IMO, this shows that we should have
> proper concurrency notes for more of our concurrent code.
OK for 2.25. Please feel free to commit follow-up comment fixes too if
needed.
Siddhesh