Re: [PATCH] [BZ #20985] robust mutexes: Fix broken x86 assembly by removing it

[Florian Weimer <fweimer at redhat dot com>]

On 12/22/2016 12:23 PM, Torvald Riegel wrote:
> On Thu, 2016-12-22 at 12:06 +0100, Florian Weimer wrote:
> > On 12/22/2016 11:22 AM, Torvald Riegel wrote:
> > >     	(LLL_ROBUST_MUTEX_LOCK_MODIFIER): New.
> >
> > This needs to be documented in the code.  It seems the code always
> > defines it as 0, so it's not clear to me why it makes sense to define it
> > at all (twice even).
>
> This should be defined differently when pthread_mutex_cond_lock.c
> includes the file; I just noticed that it doesn't do that.
>
> Is the patch OK besides that (ie, so after fixing that oversight and
> adding a suitable comment to the definition of
> LLL_ROBUST_MUTEX_LOCK_MODIFIER?).

Do we already have a test case which detects the bug you introduced?

Would you please post a consolidated patch rebased to current master?

Thanks,
Florian