This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove index defines
On Tue, 10 Jan 2017, Wilco Dijkstra wrote:
> Joseph Myers wrote:
> > On Tue, 10 Jan 2017, Wilco Dijkstra wrote:
> >
> > > As a minor cleanup remove the (r)index defines from include/string.h as
> > > they are only used internally in a few places. Rename a few uses that
> > > occur in libc.so.
> >
> > How did you identify where should be changed? Did you make sure installed
> > stripped shared libraries were unchanged by the patch?
> >
> > I see calls in hurd/path-lookup.c and sunrpc/rpc_main.c that I'd expect to
> > be similarly changed.
>
> I checked there are no local plt failures and no uses of it in the libc/libm.so.
> sunrpc/rpc_main.c seems to be an application, so it's OK to use (r)index.
That doesn't mean it's a good idea for it to use those obsolete symbols.
> I can't find the functions in hurd/path-lookup.c in any .so, in fact
> none of the files in hurd seem to be built. Is it dead or only used for
> a subset of targets?
It's built, as you would expect, for Hurd targets. Hurd and NaCl people
have not yet contributed build-many-glibcs.py patches to build unmodified
sources for those targets (or pointed to sufficiently clear instructions
on kernel headers etc. for someone unfamiliar with those targets to add
support), so they are not yet covered by that script.
--
Joseph S. Myers
joseph@codesourcery.com