This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] New condvar implementation that provides stronger ordering guarantees.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Torvald Riegel <triegel at redhat dot com>, GLIBC Devel <libc-alpha at sourceware dot org>, David Miller <davem at davemloft dot net>, Darren Hart <dvhart at infradead dot org>
- Date: Sun, 1 Jan 2017 22:56:25 -0500
- Subject: Re: [PATCH] New condvar implementation that provides stronger ordering guarantees.
- Authentication-results: sourceware.org; auth=none
- References: <1464268895.17104.14.camel@localhost.localdomain> <1465937639.31784.7.camel@localhost.localdomain> <696ddced-4efa-62ac-9fb5-01022b0437e8@redhat.com> <alpine.DEB.2.20.1612311732140.27227@digraph.polyomino.org.uk>
On 12/31/2016 12:37 PM, Joseph Myers wrote:
> In addition to hppa (as expected), it appears the build is broken for
> sparcv9 (previous discussion said it was broken for pre-v9, did the
> expected breakage change as a result of other sparc changes?).
>
> https://sourceware.org/ml/libc-testresults/2016-q4/msg00093.html
>
> For sparc64-linux-gnu I see
>
> pthread_cond_init.c: In function '__pthread_cond_init':
> pthread_cond_init.c:38:17: error: 'struct <anonymous>' has no member named
> '__wrefs'
> cond->__data.__wrefs |= __PTHREAD_COND_SHARED_MASK;
> ^
> pthread_cond_init.c:44:17: error: 'struct <anonymous>' has no member named
> '__wrefs'
> cond->__data.__wrefs |= __PTHREAD_COND_CLOCK_MONOTONIC_MASK;
> ^
> and various such errors for sparcv9-linux-gnu.
My opinion is that this has to get fixed by the ports maintainer
for SPARC, just like I'll fix this for hppa in the coming week.
You need to adapt the pthreadtypes.h structure definition
to match the same changes being done to the other architectures.
--
Cheers,
Carlos.