[PATCH] Compile tst-cleanupx4 test with -fexceptions

Mike Frysinger vapier@gentoo.org
Thu Jun 30 01:25:00 GMT 2016


On 01 Jun 2016 14:17, H.J. Lu wrote:
> tst-cleanupx4 is linked with tst-cleanupx4.o and tst-cleanup4aux.o.
> Since tst-cleanupx4.o is compiled from tst-cleanup4.c with -fexceptions,
> tst-cleanupx4.c should also be compiled with -fexceptions.

i think this last line you meant "tst-cleanupx4aux.c", or at least
generalize it to say "the aux object".

> Tested on x86-64 and i686.  OK for master?
> 
> 
> H.J.
> --
> 	[BZ 18645]

need a # before the bug number

> 	* nptl/Makefile (extra-test-objs): Add tst-cleanupx4aux.o

period at the end

nits aside, patch looks OK
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160630/14e03080/attachment.sig>


More information about the Libc-alpha mailing list