This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/4] Add framework for tunables
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Siddhesh Poyarekar <siddhesh at sourceware dot org>, <libc-alpha at sourceware dot org>, <carlos at redhat dot com>, <adhemerval dot zanella at linaro dot org>
- Date: Fri, 30 Dec 2016 13:27:55 +0000
- Subject: Re: [PATCH 1/4] Add framework for tunables
- Authentication-results: sourceware.org; auth=none
- References: <1479285306-11684-1-git-send-email-siddhesh@sourceware.org> <1479285306-11684-2-git-send-email-siddhesh@sourceware.org> <37ef7178-e83c-8318-4983-acfb3f422562@redhat.com>
On Tue, 27 Dec 2016, Florian Weimer wrote:
> > + default:
> > + __builtin_unreachable ();
>
> Should this rather be __bultin_trap?
Note that __bultin_trap generates a call to abort on some platforms. It
can only be used in places where such a call is OK; we've had problems
with the isolate-erroneous-paths optimization generating such calls. So
make sure anything using __bultin_trap builds OK for SH with
build-many-glibcs.py, for example.
--
Joseph S. Myers
joseph@codesourcery.com