This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v11] Add pretty printers for the NPTL lock types


2016-12-22 13:34 GMT-03:00 Torvald Riegel <triegel@redhat.com>:
> Is there any way to specify a different gdb binary during configure time
> or such?  I've only seen the hard-coded value in
> scripts/test_printers_common.py.

I didn't touch any configure scripts for this patch. Sid was working
on a patch for detecting the python program at configure time, perhaps
he can do something similar for gdb?

I'm personally focused on the install patch, though I don't think I'll
have it ready for 2.25 as I'm doing all this in what little free time
I have.

> Testing the pretty printers if the build host gdb isn't ready out of the
> box is quite annoying.

How so? IIRC the tests should return UNSUPPORTED when gdb is absent.
Are you seeing something different?

> It would be good if README.pretty-printers could
> be improved to cover this.

The README says:

"The tests run on the glibc host, which is assumed to have both gdb
and PExpect; if any of those is absent the tests will fail with code
77 (UNSUPPORTED)."

What do you suggest? Should it mention that the gdb binary should
actually be called "gdb" and be somewhere within PATH?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]