This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] Fix nisplus-alias compile with gcc7
- From: Richard Henderson <rth at twiddle dot net>
- To: libc-alpha at sourceware dot org
- Date: Wed, 21 Dec 2016 14:45:28 -0800
- Subject: [PATCH] Fix nisplus-alias compile with gcc7
- Authentication-results: sourceware.org; auth=none
I think the patch is fairly obvious: return error if there is no
name as opposed to if there isn't.
We follow up this check with various strlen, printf etc. It's
the latter for which gcc7 mainline warns that we pass NULL to %s,
and with -Werror that gets noticed.
r~
* nis/nss_nisplus/nisplus-alias.c (_nss_nisplus_getaliasbyname_r):
Fix test for NULL name.
---
nis/nss_nisplus/nisplus-alias.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nis/nss_nisplus/nisplus-alias.c b/nis/nss_nisplus/nisplus-alias.c
index 7f698b4..cb5acce 100644
--- a/nis/nss_nisplus/nisplus-alias.c
+++ b/nis/nss_nisplus/nisplus-alias.c
@@ -291,7 +291,7 @@ _nss_nisplus_getaliasbyname_r (const char *name, struct aliasent *alias,
return status;
}
- if (name != NULL)
+ if (name == NULL)
{
*errnop = EINVAL;
return NSS_STATUS_UNAVAIL;
--
2.9.3