This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nptl: Avoid expected SIGALRM in most tests [BZ #20432]
- From: Andreas Schwab <schwab at suse dot de>
- To: fweimer at redhat dot com (Florian Weimer)
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 15 Dec 2016 16:55:53 +0100
- Subject: Re: [PATCH] nptl: Avoid expected SIGALRM in most tests [BZ #20432]
- Authentication-results: sourceware.org; auth=none
- References: <20160817125455.B3F11439942E2@oldenburg.str.redhat.com>
On Aug 17 2016, fweimer@redhat.com (Florian Weimer) wrote:
> diff --git a/nptl/tst-stdio1.c b/nptl/tst-stdio1.c
> index 2d44c16..4250e53 100644
> --- a/nptl/tst-stdio1.c
> +++ b/nptl/tst-stdio1.c
> @@ -21,6 +21,10 @@
> #include <stdio.h>
> #include <unistd.h>
>
> +static int do_test (void);
> +
> +#define TEST_FUNCTION do_test ()
> +#include "../test-skeleton.c"
>
> static void *tf (void *a)
> {
> @@ -43,14 +47,10 @@ do_test (void)
> _exit (1);
> }
>
> - pthread_join (th, NULL);
> + delayed_exit (1);
> + xpthread_join (th);
>
> puts ("join returned");
>
> - return 0;
> + return 1;
> }
> -
> -
> -#define EXPECTED_SIGNAL SIGALRM
> -#define TEST_FUNCTION do_test ()
> -#include "../test-skeleton.c"
That doesn't work, the test now always times out because exit blocks on
flockfile.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."