This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/8] float128: Add wrappers for IEEE functions.
On Fri, 9 Dec 2016, Gabriel F. T. Gomes wrote:
> On Wed, 7 Dec 2016 21:47:28 +0000
> Joseph Myers <joseph@codesourcery.com> wrote:
>
> > For log1p, I'd expect the template file to use -1 (or M_LIT (-1.0) in the
> > islessequal call) rather than the double value -1.0. And I'd hope that
> > you can remove the ldbl-128ibm/w_log1pl.c and ldbl-64-128/w_log1pl.c files
> > completely and the generated file will do the right thing automatically.
>
> I attached a new version with the suggested changes.
This patch is OK.
(For the record for anyone wondering: in this case it's correct that the
template does not use M_LIBM_NEED_COMPAT, because the compat symbol for
long double = double on architectures where it changed points directly to
the underlying implementation that does not set errno.)
--
Joseph S. Myers
joseph@codesourcery.com