This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 08 Dec 2016 12:15, Carlos O'Donell wrote: > +static void * > +worker( void *arg ) seems like this test case is mingling code from diff sources since it has diff styles. there's a number of non-GNU style errors in it -- this is just the first one i saw. > +{ > + int ret; > + unsigned int iter = 0; > + struct passwd pwbuf, *pw; > + uid_t uid; > + uid = geteuid(); > + /* Use a reasonable sized buffer. Note that _SC_GETPW_R_SIZE_MAX is > + just a hint and not any kind of maximum value. */ > + wbufsz = sysconf(_SC_GETPW_R_SIZE_MAX); > + if (wbufsz == -1) > + wbufsz = 1024; > + wbuf = xmalloc (wbufsz); > + pthread_cleanup_push (worker_free, wbuf); > + sem_post (&started); > + while (1) this func could do with a few newlines sprinkled around. it's pretty dense to read as-is. actually the whole testcase is written this way :). > + printf ("INFO: Previoulsy we would never get here\n"); "Previously" > + printf ("PASS: Cancelled getpwuid_r successfully" "Canceled" -mike
Attachment:
signature.asc
Description: Digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |