This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/3] New string function explicit_bzero (from OpenBSD).
On Thu, Dec 8, 2016 at 12:13 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Thu, 8 Dec 2016, Zack Weinberg wrote:
>
>> + # used by libcrypt
>> + __explicit_bzero;
>
> Use by libcrypt would be sufficient reason for a GLIBC_PRIVATE export;
> it's not clear it's sufficient for a GLIBC_2.25 public symbol version
> export, absent a general position on adding such exports of
> implementation-namespace names.
Fair point, I will change it to GLIBC_PRIVATE.
[...]
You are again doing this annoying thing you do where you send a small
number of review comments with no indication of whether you have any
other comments or concerns, whether you want to see these comments
addressed before you look at the patches any more, or whether you are
approving (or have the authority to approve) the patch series.
Given the short time to the 2.25 deadline and my own limited time
before I go out of town, I do not intend to rework this patch series
any further unless it is approved in principle for 2.25, and not until
I receive a _complete_ list of things that need to be changed before
it can be committed.
zw