This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/3] New string function explicit_bzero (from OpenBSD).
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 8 Dec 2016 17:13:52 +0000
- Subject: Re: [PATCH 1/3] New string function explicit_bzero (from OpenBSD).
- Authentication-results: sourceware.org; auth=none
- References: <20161208145606.3568-1-zackw@panix.com> <20161208145606.3568-2-zackw@panix.com>
On Thu, 8 Dec 2016, Zack Weinberg wrote:
> + # used by libcrypt
> + __explicit_bzero;
Use by libcrypt would be sufficient reason for a GLIBC_PRIVATE export;
it's not clear it's sufficient for a GLIBC_2.25 public symbol version
export, absent a general position on adding such exports of
implementation-namespace names.
> diff --git a/string/explicit_bzero.c b/string/explicit_bzero.c
> new file mode 100644
> index 0000000000..6c3dc9aedb
> --- /dev/null
> +++ b/string/explicit_bzero.c
> @@ -0,0 +1,33 @@
> +/* Copyright (C) 2016 Free Software Foundation, Inc.
Missing descriptive comment as first line of new file.
> diff --git a/string/read_memory.c b/string/read_memory.c
> new file mode 100644
> index 0000000000..c4a5990c49
> --- /dev/null
> +++ b/string/read_memory.c
> @@ -0,0 +1,41 @@
> +/* Copyright (C) 2016 Free Software Foundation, Inc.
Likewise.
--
Joseph S. Myers
joseph@codesourcery.com