This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use XSTAT_IS_XSTAT64 in generic xstat functions
- From: Steve Ellcey <sellcey at caviumnetworks dot com>
- To: <libc-alpha at sourceware dot org>
- Date: Mon, 28 Nov 2016 10:52:12 -0800
- Subject: Re: [PATCH] Use XSTAT_IS_XSTAT64 in generic xstat functions
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <1479756063.14643.8.camel@caviumnetworks.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Ping. I double checked this patch and did a alpha build with the
build-many-glibcs.py script to make sure it did not have the same
problem that my [f]statfs patch had on that target.
Steve Ellcey
sellcey@caviumnetworks.com
On Mon, 2016-11-21 at 11:21 -0800, Steve Ellcey wrote:
> Here is a new version of my patch to use XSTAT_IS_XSTAT64 in generic 32
> bit xstat routines. This is needed for the aarch64 ILP32 work where
> the xstat and xstat64 routines can be aliased. This patch uses #if's
> instead of #ifdef's since my earlier patch defined XSTAT_IS_XSTAT64 to
> 0 or 1 in all of the kernel_stat.h header files.
>
> Tested on x86 and aarch64. OK to checkin?
>
> Steve Ellcey
> sellcey@caviumnetworks.com
>
>
> 2016-11-21 Yury Norov <ynorov@caviumnetworks.com>
> Steve Ellcey <sellcey@caviumnetworks.com>
>
> * sysdeps/unix/sysv/linux/generic/wordsize-32/fxstat.c: Do not define
> fxstat if XSTAT_IS_XSTAT64 is set to non-zero.
> * sysdeps/unix/sysv/linux/generic/wordsize-32/fxstatat.c: Ditto for
> fxstatat.
> * sysdeps/unix/sysv/linux/generic/wordsize-32/lxstat.c: Ditto for
> lxstat.
> * sysdeps/unix/sysv/linux/generic/wordsize-32/xstat.c: Ditto for xstat.
> * sysdeps/unix/sysv/linux/generic/wordsize-32/fxstat64.c: New file.
> * sysdeps/unix/sysv/linux/generic/wordsize-32/fxstatat64.c: New file.
> * sysdeps/unix/sysv/linux/generic/wordsize-32/lxstat64.c: Make __lxstat
> an alias of __lxstat64 if XSTAT_IS_XSTAT64 is set to non-zero.
> * sysdeps/unix/sysv/linux/generic/wordsize-32/xstat64.c: Ditto for
> __xstat.