Re: [PATCH v2] linux ttyname and ttyname_r: do not return wrong results

["Dmitry V. Levin" <ldv at altlinux dot org>]

On Thu, Nov 24, 2016 at 02:17:13AM +0100, Christian Brauner wrote:
> On Thu, Nov 24, 2016 at 03:48:58AM +0300, Dmitry V. Levin wrote:
> > On Tue, Nov 22, 2016 at 03:29:53AM +0100, Christian Brauner wrote:
[...]
> > > diff --git a/sysdeps/unix/sysv/linux/ttyname.h b/sysdeps/unix/sysv/linux/ttyname.h
> > > new file mode 100644
> > > index 0000000..19af6e6
> > > --- /dev/null
> > > +++ b/sysdeps/unix/sysv/linux/ttyname.h
> > > @@ -0,0 +1,35 @@
> > > +/* Copyright (C) 2004-2016 Free Software Foundation, Inc.
> > > +   This file is part of the GNU C Library.
> > 
> > This file looks like a new one, so could you explain where does this
> > year range come from?
> 
> Sorry, the header file was copied over from another header file. I corrected the
> year in the patch I'm going to send out in a minute.
> 
> > BTW, the added copyright notice means that the change is legally
> > significant.  If this is the case, could you explain your current
> > FSF copyright assignment status, please?
> 
> So far I have not signed any FSF copyright assignment form. If this is
> absolutely necessary, I will do so but since we were requested to add a new
> simple header file it would be much appreciated if we could avoid this. At least
> you could maybe apply the patch and then send me the form.

Assuming that this is your first contribution to glibc, and the change is
below the threshold of 15 lines of code that is legally significant for
copyright purposes, you don't have to sign a copyright assignment yet.

By adding a copyright notice to the new file, however, you state that
the contribution is legally significant.  If this is the case, then
a copyright assignment must be signed before this change could be merged.

This is just my understanding of
https://www.gnu.org/prep/maintain/maintain.html#Legally-Significant,
there are people responsible for glibc to the GNU Project
(https://sourceware.org/glibc/wiki/MAINTAINERS#Project_stewards_.28GNU_package_maintainers.29)
who have the final say on these matters.


-- 
ldv

Attachment: pgprzC47sin8X.pgp
Description: PGP signature