This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] assert.h: allow gcc to detect assert(a = 1) errors
- From: Florian Weimer <fweimer at redhat dot com>
- To: Jim Meyering <jim at meyering dot net>, Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 24 Nov 2016 08:36:48 +0100
- Subject: Re: [PATCH] assert.h: allow gcc to detect assert(a = 1) errors
- Authentication-results: sourceware.org; auth=none
- References: <1405537923-28692-1-git-send-email-jim@meyering.net> <20140716201505.34FF22C398F@topped-with-meat.com> <CA+8g5KH_vG9KY-fT8miGH9oSULCoffd5DQQbgr-GDR6d2qTktA@mail.gmail.com> <CA+8g5KFy4tk+H3t0BKoe=wQqsW+ea3ZtzOe2bb+xBUNbtxGBWg@mail.gmail.com>
On 11/24/2016 03:21 AM, Jim Meyering wrote:
We *do* need that __STRICT_ANSI__ disjunct.
Otherwise, this would evoke no warning:
$ gcc -isystem. -I. -Werror=pedantic k.c
In file included from k.c:1:0:
k.c: In function ‘main’:
k.c:2:23: warning: ISO C forbids braced-groups within expressions [-Wpedantic]
int main() { assert ( ({1;}) ); return 0; }
Agreed.
Tests I ran manually in a directory with the new assert.h file:
Do you require a test suite addition for these? If so, would a single
bourne shell script be acceptable?
We currently lack the machinery for that. It's not just that it would
need a shell script. We also do not compile tests with headers as
system headers.
The patch looks good to me, but it needs a ChangeLog entry.
Thanks,
Florian