This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] dbl-64/e_sqrt.c: fix -Wunused-variable
- From: Yury Norov <ynorov at caviumnetworks dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 23 Nov 2016 22:26:13 +0530
- Subject: Re: [PATCH] dbl-64/e_sqrt.c: fix -Wunused-variable
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Yuri dot Norov at caviumnetworks dot com;
- References: <1476979623-890-1-git-send-email-ynorov@caviumnetworks.com> <mvmwpfuup5c.fsf@hawking.suse.de>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Wed, Nov 23, 2016 at 05:39:11PM +0100, Andreas Schwab wrote:
> On Okt 20 2016, Yury Norov <ynorov@caviumnetworks.com> wrote:
>
> > EMULV() doesn't need p, hx, tx and ty if DLA_FMS is defined.
> > If that variables are needed for EMULV() only, GCC warns about
> > unused variables, like this:
> >
> > ../sysdeps/ieee754/dbl-64/e_sqrt.c: In function ‘__ieee754_sqrt’:
> > ../sysdeps/ieee754/dbl-64/e_sqrt.c:56:54: warning: unused variable ‘ty’ [-Wunused-variable]
> > double y, t, del, res, res1, hy, z, zz, p, hx, tx, ty, s;
> > ^
> > This patch fixes it for sysdeps/ieee754/dbl-64/e_sqrt.c where it happens.
>
> You only need that because you are getting the sysdep dir order wrong.
> This file should not be used on aarch64, but rather the one in
> sysdeps/aarch64/fpu.
Yes, it works. Thank you.
Yury.