This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Add write_message_to_stderr and use it instead of write

On Mon, 7 Nov 2016 18:32:28 +0100
Florian Weimer <fweimer@redhat.com> wrote:

> On 11/01/2016 01:43 AM, Gabriel F. T. Gomes wrote:
> >
> > +/* Write a message to standard error.  Can be used in signal handlers.  */
> > +static void
> > +__attribute__ ((unused))
> > +write_message_to_stderr (const char *message)
> > +{
> > +  ssize_t unused __attribute__ ((unused));
> > +  unused = write (STDERR_FILENO, message, strlen (message));
> > +}  
> 
> These messages should really go to standard output, so you can adjust 
> the tests to use plain write_message instead and drop this hunk.

Thanks.  Pushed with the changes as e0c68519.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]