This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix -Wformat-length warning in time/tst-strptime2.c
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Steve Ellcey <sellcey at caviumnetworks dot com>, libc-alpha at sourceware dot org
- Date: Wed, 2 Nov 2016 16:55:25 -0400
- Subject: Re: [PATCH] Fix -Wformat-length warning in time/tst-strptime2.c
- Authentication-results: sourceware.org; auth=none
- References: <1477326501.8523.51.camel@caviumnetworks.com> <1478116026.2891.53.camel@caviumnetworks.com>
On 11/02/2016 03:47 PM, Steve Ellcey wrote:
> Here is an updated version of my earlier patch, I hadn't tested the
> original one with an old GCC so I hadn't realized I needed to put the
> DIAG_IGNORE_NEEDS_COMMENT in an ifdef. This version was tested with
> GCC 5.4 and GCC 7.0 with no regressions.
>
> I also double checked that the test program is deliberately using
> snprintf to truncate the output so changing the test by increasing the
> buffer size and avoiding the warnings that way would change what was
> being tested.
>
> OK to checkin?
LGTM.
c.